Update dcgan_faces_tutorial.py #816
Conversation
Previous comment might have been slightly misleading. A bit easier to understand, if made explicit, that gradients of errD_real and errD_fake w.r.t. parameters of netD get added up/accumulated because of the successive backward calls without a zero_grad() in between.
|
Deploy preview for pytorch-tutorials-preview ready! Built with commit b65fcc6 https://deploy-preview-816--pytorch-tutorials-preview.netlify.com |
|
Rebased and testing now on our recent build update. |
|
Deploy preview for pytorch-tutorials-preview ready! Built with commit 8f1e958 https://deploy-preview-816--pytorch-tutorials-preview.netlify.app |
|
Hi @samarth4149! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Hi @samarth4149! Can you sign the CLA agreement so that I can merge the pull request? Thanks! |
|
Done, thanks |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
* Update dcgan_faces_tutorial.py Previous comment might have been slightly misleading. A bit easier to understand, if made explicit, that gradients of errD_real and errD_fake w.r.t. parameters of netD get added up/accumulated because of the successive backward calls without a zero_grad() in between. * Update dcgan_faces_tutorial.py Co-authored-by: Brian Johnson <brianjo@fb.com> Co-authored-by: holly1238 <77758406+holly1238@users.noreply.github.com>
Previous comment might have been slightly misleading. A bit easier to understand, if made explicit, that gradients of errD_real and errD_fake w.r.t. parameters of netD get added up/accumulated because of the successive backward calls without a zero_grad() in between.